Issue 6893057: Fix a bug in a corner case of direct eval detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6893057: Fix a bug in a corner case of direct eval detection. (Closed)

Created:
9 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix a bug in a corner case of direct eval detection. The corner case is calling a function named 'eval' that is looked up at runtime and found in a non-global context (but not an extension object). The bug is that we used the function itself as the receiver rather than using the global object. R=ager@chromium.org TEST=has been added to the eval mjsunit test Committed: http://code.google.com/p/v8/source/detail?r=7696

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	test/mjsunit/eval.js	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages