chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: make this patch applicable to the latest trunk Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index b90a07ba7be59133bac3fb7f6e5e4a443fd089f2..4b48bbe4941a90f4be05cb8be3ef975f0d66cec1 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/bookmarks/bookmark_utils.h"

#include "chrome/browser/browser_shutdown.h"

#include "chrome/browser/defaults.h"

+#include "chrome/browser/event_disposition.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

@@ -203,7 +204,7 @@ class BookmarkFolderButton : public views::MenuButton {

return false;

WindowOpenDisposition disposition(

- event_utils::DispositionFromEventFlags(e.flags()));

+ browser::DispositionFromEventFlags(e.flags()));

return disposition != CURRENT_TAB;

}

@@ -1087,7 +1088,7 @@ void BookmarkBarView::ButtonPressed(views::Button* sender,

DCHECK(page_navigator_);

WindowOpenDisposition disposition_from_event_flags =

- event_utils::DispositionFromEventFlags(sender->mouse_event_flags());

+ browser::DispositionFromEventFlags(sender->mouse_event_flags());

if (node->is_url()) {

RecordAppLaunch(profile_, node->GetURL());