chrome/browser/ui/gtk/menu_gtk.cc - Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/menu_gtk.cc

Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: make event_utils::DispositionFromEventFlags not view-specific. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/event_disposition_utils.h ('K') | « chrome/browser/ui/gtk/gtk_util.cc ('k') | chrome/browser/ui/tab_contents/tab_contents_wrapper_delegate.h » ('j') | chrome/browser/ui/tab_contents/tab_contents_wrapper_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/menu_gtk.cc

diff --git a/chrome/browser/ui/gtk/menu_gtk.cc b/chrome/browser/ui/gtk/menu_gtk.cc

index d1205792c50a9ba6501c316b28c5fac31caaa5c8..838023ee5993a5811eb2a861bec7caf1a5ed7f3d 100644

--- a/chrome/browser/ui/gtk/menu_gtk.cc

+++ b/chrome/browser/ui/gtk/menu_gtk.cc

@@ -20,7 +20,7 @@

#include "ui/base/models/button_menu_item_model.h"

#include "ui/base/models/menu_model.h"

#include "ui/gfx/gtk_util.h"

-#include "webkit/glue/window_open_disposition.h"

+#include "views/events/event.h"

bool MenuGtk::block_activation_ = false;

@@ -707,8 +707,8 @@ void MenuGtk::ExecuteCommand(ui::MenuModel* model, int id) {

GdkEvent* event = gtk_get_current_event();

if (event && event->type == GDK_BUTTON_RELEASE) {

- model->ActivatedAtWithDisposition(

- id, event_utils::DispositionFromEventFlags(event->button.state));

+ int flags = event_utils::GetEventFlagsFromGdkState(event->button.state);

+ model->ActivatedAtWithFlags(id, flags);

} else {

model->ActivatedAt(id);

}