added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward.

chrome/browser/ui/browser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include <windows.h>
 #endif  // OS_WIN
@@ skipping 1255 matching lines @@
   bool can_close = !watcher || watcher->CanCloseBrowser(this);
   if (!can_close && is_attempting_to_close_browser_)
     CancelWindowClose();
   return can_close;
 }
 
 void Browser::GoBack(WindowOpenDisposition disposition) {
   UserMetrics::RecordAction(UserMetricsAction("Back"));
 
   TabContentsWrapper* current_tab = GetSelectedTabContentsWrapper();
-  if (current_tab->controller().CanGoBack()) {
-    TabContents* new_tab = GetOrCloneTabForDisposition(disposition);
+  if (!current_tab->controller().CanGoBack())
+    return;
+
+  if (disposition == NEW_WINDOW) {
+    TabContentsWrapper* new_wrapper = current_tab->Clone();
+
     // If we are on an interstitial page and clone the tab, it won't be copied
     // to the new tab, so we don't need to go back.
     if (current_tab->tab_contents()->showing_interstitial_page() &&
+        (new_wrapper->tab_contents() != current_tab->tab_contents()))
+      return;
+
+    new_wrapper->tab_contents()->controller().GoBack();
+
+    // Make a new normal browser window.
+    Browser* browser = new Browser(Browser::TYPE_NORMAL, profile_);
+    browser->InitBrowserWindow();
+    browser->AddTab(new_wrapper, PageTransition::LINK);
+    browser->window()->Show();
+  } else {
+    TabContents* new_tab = GetOrCloneTabForDisposition(disposition);
+
+    if (current_tab->tab_contents()->showing_interstitial_page() &&
         (new_tab != current_tab->tab_contents()))
       return;
+
     new_tab->controller().GoBack();
   }
 }
 
 void Browser::GoForward(WindowOpenDisposition disposition) {
   UserMetrics::RecordAction(UserMetricsAction("Forward"));
-  if (GetSelectedTabContentsWrapper()->controller().CanGoForward())
+
+  TabContentsWrapper* current_tab = GetSelectedTabContentsWrapper();
+  if (!current_tab->controller().CanGoForward())
+    return;
+
+  if (disposition == NEW_WINDOW) {
+    TabContentsWrapper* new_wrapper = current_tab->Clone();
+
+    new_wrapper->tab_contents()->controller().GoForward();
+
+    // Make a new normal browser window.
+    Browser* browser = new Browser(Browser::TYPE_NORMAL, profile_);

[brettw, 2011/05/03 19:43:53]

It seems like this logic should be inside GetOrCloneTabForDisposition so you
don't have to duplicate it. It looks like all you have to do is implement
knowledge of "new window" in that function and the existing code in
GoForward/Back will work.

+    browser->InitBrowserWindow();
+    browser->AddTab(new_wrapper, PageTransition::LINK);
+    browser->window()->Show();
+  } else {
     GetOrCloneTabForDisposition(disposition)->controller().GoForward();
+  }
 }
 
 void Browser::Reload(WindowOpenDisposition disposition) {
   UserMetrics::RecordAction(UserMetricsAction("Reload"));
   ReloadInternal(disposition, false);
 }
 
 void Browser::ReloadIgnoringCache(WindowOpenDisposition disposition) {
   UserMetrics::RecordAction(UserMetricsAction("ReloadIgnoringCache"));
   ReloadInternal(disposition, true);
@@ skipping 3159 matching lines @@
   TabContents* current_tab = GetSelectedTabContents();
   if (current_tab) {
     content_restrictions = current_tab->content_restrictions();
     NavigationEntry* active_entry = current_tab->controller().GetActiveEntry();
     // See comment in UpdateCommandsForTabState about why we call url().
     if (!SavePackage::IsSavableURL(active_entry ? active_entry->url() : GURL()))
       content_restrictions |= CONTENT_RESTRICTION_SAVE;
   }
   return content_restrictions;
 }