added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward.

ui/base/models/simple_menu_model.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_MODELS_SIMPLE_MENU_MODEL_H_
 #define UI_BASE_MODELS_SIMPLE_MENU_MODEL_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 30 matching lines @@
     // Gets the icon for the item with the specified id, returning true if there
     // is an icon, false otherwise.
     virtual bool GetIconForCommandId(int command_id, SkBitmap* icon) const;
 
     // Notifies the delegate that the item with the specified command id was
     // visually highlighted within the menu.
     virtual void CommandIdHighlighted(int command_id);
 
     // Performs the action associated with the specified command id.
     virtual void ExecuteCommand(int command_id) = 0;
+    virtual void ExecuteCommandWithDisposition(int command_id,
+                                               int disposition);
 
     // Notifies the delegate that the menu is about to show.
     virtual void MenuWillShow();
 
     // Notifies the delegate that the menu has closed.
     virtual void MenuClosed();
 
    protected:
     virtual ~Delegate() {}
   };
@@ skipping 54 matching lines @@
                                 ui::Accelerator* accelerator) const OVERRIDE;
   virtual bool IsItemCheckedAt(int index) const OVERRIDE;
   virtual int GetGroupIdAt(int index) const OVERRIDE;
   virtual bool GetIconAt(int index, SkBitmap* icon) OVERRIDE;
   virtual ui::ButtonMenuItemModel* GetButtonMenuItemAt(
       int index) const OVERRIDE;
   virtual bool IsEnabledAt(int index) const OVERRIDE;
   virtual bool IsVisibleAt(int index) const OVERRIDE;
   virtual void HighlightChangedTo(int index) OVERRIDE;
   virtual void ActivatedAt(int index) OVERRIDE;
+  virtual void ActivatedAtWithDisposition(int index, int disposition) OVERRIDE;

[Ben Goodger (Google), 2011/05/13 19:46:26]

This is an implicit coupling between this model code and a WebKit concept -
WindowOpenDisposition. Even if you don't expose the type here, the
calling/receiving code expects it.

Why does the model need to know about the disposition?

In fact, who even calls this method? I don't see any callers in this CL.

   virtual MenuModel* GetSubmenuModelAt(int index) const OVERRIDE;
   virtual void MenuWillShow() OVERRIDE;
   virtual void MenuClosed() OVERRIDE;
   virtual void SetMenuModelDelegate(
       ui::MenuModelDelegate* menu_model_delegate) OVERRIDE;
 
  protected:
   // Some variants of this model (SystemMenuModel) relies on items to be
   // inserted backwards. This is counter-intuitive for the API, so rather than
   // forcing customers to insert things backwards, we return the indices
@@ skipping 23 matching lines @@
   MenuModelDelegate* menu_model_delegate_;
 
   ScopedRunnableMethodFactory<SimpleMenuModel> method_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SimpleMenuModel);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_MODELS_SIMPLE_MENU_MODEL_H_