Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 6891008: Updating DCHECK() usage. (Closed)

Created:
9 years, 8 months ago by KushalP
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, pam+watch_chromium.org, apatrick_chromium, jshin+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update DCHECK() usage to utilize the more expressive debugging functions. BUG=58409 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M base/i18n/icu_string_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/pickle.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/rand_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/shared_memory_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sync_socket_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sync_socket_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/time_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/common_decoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
KushalP
And I've compiled everything locally (Mac) and it works fine. Would appreciate it if someone ...
9 years, 8 months ago (2011-04-21 21:27:11 UTC) #1
Peter Kasting
LGTM
9 years, 8 months ago (2011-04-21 21:38:22 UTC) #2
KushalP
Great! Does it need to go through the tryservers first because of the edit to ...
9 years, 8 months ago (2011-04-21 22:47:29 UTC) #3
tfarina
On 2011/04/21 22:47:29, KushalP wrote: > Great! Does it need to go through the tryservers ...
9 years, 8 months ago (2011-04-21 22:49:30 UTC) #4
tfarina
Also, please could you remove: "I've CC'ed you all as you've been following this issue ...
9 years, 8 months ago (2011-04-21 22:52:51 UTC) #5
KushalP
Updated. Sorry, I thought that was the messages system and not the bug description. On ...
9 years, 8 months ago (2011-04-21 23:09:33 UTC) #6
KushalP
Is that description good enough? I've got more verbose (local) commits for each folder and ...
9 years, 8 months ago (2011-04-21 23:11:02 UTC) #7
willchan no longer on Chromium
LGTM
9 years, 8 months ago (2011-04-22 11:36:11 UTC) #8
KushalP
Cool. Can someone push this through the tryservers for me please? On 2011/04/22 11:36:11, willchan ...
9 years, 8 months ago (2011-04-22 12:13:59 UTC) #9
willchan no longer on Chromium
I checked the commit checkbox. On 2011/04/22 12:13:59, KushalP wrote: > Cool. Can someone push ...
9 years, 8 months ago (2011-04-22 12:17:15 UTC) #10
commit-bot: I haz the power
9 years, 8 months ago (2011-04-22 13:13:09 UTC) #11
Change committed as 82639

Powered by Google App Engine
This is Rietveld 408576698