Add post_process argument to Checkout.apply_patch().

Add post_process argument to Checkout.apply_patch().

This enables doing late modifications like updating the copyright notice or fixing line endings.

Also silence the checkout operations a bit more when VOID=subprocess2.VOID.

Add corresponding unit tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82587

[M-A Ruel, 2011-04-21 19:37:23]

Required for http://codereview.chromium.org/6880115/

[Dirk Pranke, 2011-04-21 20:28:02]

LGTM.

http://codereview.chromium.org/6891003/diff/1/checkout.py
File checkout.py (right):

http://codereview.chromium.org/6891003/diff/1/checkout.py#newcode132
checkout.py:132: for post in post_process:
I probably wouldn't call this 'post', simply because of the association I have
with posting messages or http requests. Maybe 'process', or 'processor', or
'handler', or 'callback' or 'fn' or something more generic?

[M-A Ruel, 2011-04-21 20:37:33]

http://codereview.chromium.org/6891003/diff/1/checkout.py
File checkout.py (right):

http://codereview.chromium.org/6891003/diff/1/checkout.py#newcode132
checkout.py:132: for post in post_process:
On 2011/04/21 20:28:02, Dirk Pranke wrote:
> I probably wouldn't call this 'post', simply because of the association I have
> with posting messages or http requests. Maybe 'process', or 'processor', or
> 'handler', or 'callback' or 'fn' or something more generic?

post_processors? Otherwise "process" or "processor" is even more generic.

[Dirk Pranke, 2011-04-21 21:54:39]

On 2011/04/21 20:37:33, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/6891003/diff/1/checkout.py
> File checkout.py (right):
> 
> http://codereview.chromium.org/6891003/diff/1/checkout.py#newcode132
> checkout.py:132: for post in post_process:
> On 2011/04/21 20:28:02, Dirk Pranke wrote:
> > I probably wouldn't call this 'post', simply because of the association I
have
> > with posting messages or http requests. Maybe 'process', or 'processor', or
> > 'handler', or 'callback' or 'fn' or something more generic?
> 
> post_processors? Otherwise "process" or "processor" is even more generic.
 
post_processor seems fine.