Issue 6889019: Partial revert of 82061 so we keep the initial unbounded range request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6889019: Partial revert of 82061 so we keep the initial unbounded range request. (Closed)

Created:
9 years, 7 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Description

Partial revert of 82061 so we keep the initial unbounded range request. Also loosened restrictions for detecting servers that support range requests. Sending "Accept-Ranges: bytes" is optional so if we attempt a range request and a server replies correctly we should assume that it does indeed support range requests. BUG=80187 TEST=test_shell_tests --gtest_filter=Buffered* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83942

Patch Set 1 #

Patch Set 2 : tests #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -13 lines)			Patch
M	webkit/glue/media/buffered_resource_loader.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	webkit/glue/media/buffered_resource_loader.cc	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
M	webkit/glue/media/buffered_resource_loader_unittest.cc	View	1	2 chunks	+50 lines, -3 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

9 years, 7 months ago (2011-05-03 17:19:56 UTC) #1

LGTM

http://codereview.chromium.org/6889019/diff/1001/webkit/glue/media/buffered_r...
File webkit/glue/media/buffered_resource_loader_unittest.cc (right):

http://codereview.chromium.org/6889019/diff/1001/webkit/glue/media/buffered_r...
webkit/glue/media/buffered_resource_loader_unittest.cc:173:
EXPECT_EQ(content_length, loader_->content_length());
I believe content_length is how much data was in the response. instance_size is
the total size of the resource.
content_length = b-a+1
instance_size = c

Expand Messages | Collapse Messages