Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 6884001: Enforce no more includes through DEPS. I also added DEPS checking for gpu/plugin/worker directori... (Closed)

Created:
9 years, 8 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Enforce no more includes through DEPS. I also added DEPS checking for gpu/plugin/worker directories as well. I've moved the breakpad specific code out of content\renderer\renderer_main.cc into chrome\renderer\chrome_render_process_observer.cc. I've also moved the rest of the process-specific initialization from chrome_content_renderer_client.cc there as well, so that all the chrome renderer process init code is one place (some of it existed before chrome_render_process_observer.cc was created). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81979

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -250 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 6 chunks +0 lines, -99 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 5 chunks +244 lines, -16 lines 0 comments Download
M content/gpu/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/plugin/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +2 lines, -7 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_glue.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 3 chunks +0 lines, -124 lines 0 comments Download
M content/worker/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
These are the DEPs change from http://codereview.chromium.org/6874038/, I didn't commit them with the change since ...
9 years, 8 months ago (2011-04-18 17:38:58 UTC) #1
jam
9 years, 8 months ago (2011-04-18 17:39:34 UTC) #2
jam
actually hold off on reviewing this please
9 years, 8 months ago (2011-04-18 17:42:29 UTC) #3
Avi (use Gerrit)
On 2011/04/18 17:42:29, John Abd-El-Malek wrote: > actually hold off on reviewing this please OK; ...
9 years, 8 months ago (2011-04-18 17:51:27 UTC) #4
jam
On 2011/04/18 17:51:27, Avi wrote: > On 2011/04/18 17:42:29, John Abd-El-Malek wrote: > > actually ...
9 years, 8 months ago (2011-04-18 18:06:05 UTC) #5
Avi (use Gerrit)
9 years, 8 months ago (2011-04-18 18:09:24 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698