Hide translate infobar on programmatic navigation.

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 1191 matching lines @@
   NotificationDetails det = NotificationService::NoDetails();
   if (details)
       det = Details<LoadNotificationDetails>(details);
   NotificationService::current()->Notify(type,
       Source<NavigationController>(&controller_),
       det);
 }
 
 void TabContents::ExpireInfoBars(
     const NavigationController::LoadCommittedDetails& details) {
-  // Only hide InfoBars when the user has done something that makes the main
-  // frame load. We don't want various automatic or subframe navigations making
-  // it disappear.
-  if (!details.is_user_initiated_main_frame_load())
-    return;
+  bool non_user_initiated_load = !details.is_user_initiated_main_frame_load();
 
   // NOTE: It is not safe to change the following code to count upwards or use
   // iterators, as the RemoveInfoBar() call synchronously modifies our delegate
   // list.
   for (size_t i = infobar_count(); i > 0; --i) {
     InfoBarDelegate* delegate = GetInfoBarDelegateAt(i - 1);
+    if (non_user_initiated_load &&

[MAD, 2011/05/13 12:41:56]

I think the coding style asks for {} when the condition spans over more than one
line.

+        delegate->DoNotCloseOnProgrammaticNavigation())

[brettw, 2011/05/13 17:04:45]

It's not clear why we need this extra function. Can't everything be implemented
in ShouldExpire? (which you had to provide an implementation of anyway, it looks
like).

+        continue;

[MAD, 2011/05/13 12:41:56]

Too much indent, should be brought back two spaces...

+
     if (delegate->ShouldExpire(details))
       RemoveInfoBar(delegate);
   }
 }
 
 WebUI* TabContents::GetWebUIForCurrentState() {
   // When there is a pending navigation entry, we want to use the pending WebUI
   // that goes along with it to control the basic flags. For example, we want to
   // show the pending URL in the URL bar, so we want the display_url flag to
   // be from the pending entry.
@@ skipping 1008 matching lines @@
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }
 
 void TabContents::OnOnlineStateChanged(bool online) {
   render_view_host()->Send(new ViewMsg_NetworkStateChanged(
       render_view_host()->routing_id(), online));
 }