Hide translate infobar on programmatic navigation.

chrome/browser/tab_contents/infobar_delegate.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/infobar_delegate.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "content/browser/tab_contents/navigation_controller.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "content/browser/tab_contents/tab_contents.h"
 
 // InfoBarDelegate ------------------------------------------------------------
 
 InfoBarDelegate::~InfoBarDelegate() {
 }
 
 bool InfoBarDelegate::EqualsDelegate(InfoBarDelegate* delegate) const {
   return false;
 }
 
 bool InfoBarDelegate::ShouldExpire(
     const NavigationController::LoadCommittedDetails& details) const {
+  // Only hide InfoBars when the user has done something that makes the main
+  // frame load. We don't want various automatic or subframe navigations making
+  // it disappear.
+  if (!details.is_user_initiated_main_frame_load())

[MAD, 2011/05/02 19:18:02]

Why not do this as part of another method, that only the translate bar
overloads?

This way, the translate bar wouldn't have to duplicate the code below, and keep
it in sync... Unless we prefer to put what's below in a shared method...

+      return false;
+
   return (contents_unique_id_ != details.entry->unique_id()) ||
       (PageTransition::StripQualifier(details.entry->transition_type()) ==
           PageTransition::RELOAD);
 }
 
 void InfoBarDelegate::InfoBarDismissed() {
 }
 
 void InfoBarDelegate::InfoBarClosed() {
 }
@@ skipping 35 matching lines @@
 InfoBarDelegate::InfoBarDelegate(TabContents* contents)
     : contents_unique_id_(0) {
   if (contents)
     StoreActiveEntryUniqueID(contents);
 }
 
 void InfoBarDelegate::StoreActiveEntryUniqueID(TabContents* contents) {
   NavigationEntry* active_entry = contents->controller().GetActiveEntry();
   contents_unique_id_ = active_entry ? active_entry->unique_id() : 0;
 }