Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 6883263: Remove unmaintained "gclient export" command, (Closed)

Created:
9 years, 7 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Remove unmaintained "gclient export" command, introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=20990 It was intended for the tarball generation script, but there was a better and simpler way. BUG=80549 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83708

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -52 lines) Patch
M gclient.py View 1 2 chunks +1 line, -22 lines 0 comments Download
M gclient_scm.py View 3 chunks +1 line, -25 lines 0 comments Download
M tests/gclient_scm_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/gclient_smoketest.py View 2 chunks +0 lines, -2 lines 0 comments Download
M zsh-goodies/_gclient View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
9 years, 7 months ago (2011-04-29 13:42:40 UTC) #1
M-A Ruel
lgtm with one comment http://codereview.chromium.org/6883263/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/6883263/diff/1/gclient.py#newcode52 gclient.py:52: __version__ = "0.6.1" Update it.
9 years, 7 months ago (2011-04-29 13:51:25 UTC) #2
Paweł Hajdan Jr.
9 years, 7 months ago (2011-04-29 14:03:05 UTC) #3
I'm going to land rather outside of US working hours to avoid a possible
disruption.

http://codereview.chromium.org/6883263/diff/1/gclient.py
File gclient.py (right):

http://codereview.chromium.org/6883263/diff/1/gclient.py#newcode52
gclient.py:52: __version__ = "0.6.1"
On 2011/04/29 13:51:25, Marc-Antoine Ruel wrote:
> Update it.

Done.

Powered by Google App Engine
This is Rietveld 408576698