Issue 6883252: CHROMIUM: verity: pull up maybe_read_entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6883252: CHROMIUM: verity: pull up maybe_read_entry (Closed)

Created:
9 years, 8 months ago by Mandeep Singh Baines

Modified:
9 years, 5 months ago

Reviewers:
Paul T, Will Drewry

CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Mandeep Singh Baines, Olof Johansson

Base URL:
http://git.chromium.org/git/kernel-next.git@chromeos-2.6.38

Visibility:
Public.

Description

CHROMIUM: verity: pull up maybe_read_entry Since the latest refactoring it is now possible to pull up maybe_read_entry. I also removed the PENDING flag and instead just call is_populated. BUG=chromium-os:13872 TEST=Ran dm-verity.git unit tests. Ran platform_DMVerityCorruption on H/W. Change-Id: I59d7555dce53fc297662aef1a15d77521ef6f4cc Signed-off-by: Mandeep Singh Baines <msb@chromium.org>; R=wad@chromium.org,taysom@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2cdcb8e

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -122 lines)			Patch
M	drivers/md/dm-bht.c	View	3 chunks	+49 lines, -83 lines	1 comment	Download
M	drivers/md/dm-verity.c	View	5 chunks	+10 lines, -36 lines	0 comments	Download
M	include/linux/dm-bht.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul T

9 years, 5 months ago (2011-07-19 15:00:51 UTC) #3

LGTM

http://codereview.chromium.org/6883252/diff/1/drivers/md/dm-bht.c
File drivers/md/dm-bht.c (right):

http://codereview.chromium.org/6883252/diff/1/drivers/md/dm-bht.c#newcode822
drivers/md/dm-bht.c:822: DMCRIT("block %u at depth %u is in an error state",
block_index, depth);
Why not add the state to the error message?

Expand Messages | Collapse Messages