Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: src/builtins.cc

Issue 6883227: Fix missing writebarrier in ArraySplice builtin. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/splice-missing-wb.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index ae3dab46c3f3038a4a8157691211f1b7ec8e16ce..377de057a3e054b35fb17b54875187ee58701910 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -838,8 +838,8 @@ BUILTIN(ArraySplice) {
const int delta = actual_delete_count - item_count;
if (actual_start > 0) {
- Object** start = elms->data_start();
- memmove(start + delta, start, actual_start * kPointerSize);
+ AssertNoAllocation no_gc;
+ MoveElements(heap, &no_gc, elms, delta, elms, 0, actual_start);
}
elms = LeftTrimFixedArray(heap, elms, delta);
« no previous file with comments | « no previous file | test/mjsunit/regress/splice-missing-wb.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698