Linux: clean up the usage of "use_cups" gyp switch:

Linux: clean up the usage of "use_cups" gyp switch:

This CL removes duplication and fixes a build error
on system with no CUPS. It uses cups-config instead of
hardcoding flags.

Also, it removes a superfluous dependency on gcrypt
from chrome_browser.gypi. printing uses gcrypt explicitly,
but chrome/browser doesn't. It was just blindly copy-pasted.
I just extracted libgcrypt target to build/linux/system.gyp,
and switched to libgcrypt-config instead of hardcoding flags.

BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83489

[Paweł Hajdan Jr., 2011-04-28 09:47:10]

Please review:

thesting, sanjeevr: printing changes
mark: gyp changes

[Paweł Hajdan Jr., 2011-04-28 09:48:44]

Sorry, a typo:

thestig, sanjeevr: please review printing changes

[Lei Zhang, 2011-04-28 10:13:50]

print_preview_handler.cc changes LGTM. Apologies for the mess from the copy +
paste.

[Mark Mentovai, 2011-04-28 14:17:28]

LG otherwise

http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp#newcode208
printing/printing.gyp:208: '<!@(cups-config --cflags)',
I’d like to avoid running cups-config at all on the Mac, where it’s pointless
and returns empty strings anyway.

[Paweł Hajdan Jr., 2011-04-28 15:07:39]

http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/6883221/diff/1/printing/printing.gyp#newcode208
printing/printing.gyp:208: '<!@(cups-config --cflags)',
On 2011/04/28 14:17:28, Mark Mentovai wrote:
> I’d like to avoid running cups-config at all on the Mac, where it’s pointless
> and returns empty strings anyway.

Done.

[Mark Mentovai, 2011-04-28 15:13:53]

LGTM

http://codereview.chromium.org/6883221/diff/5001/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/6883221/diff/5001/printing/printing.gyp#newcod...
printing/printing.gyp:216: 'libraries': [
I really only wanted to get cups-config out of the Mac workflow, if you want to
put the cflags/ldflags invocations of cups-config here in the non-Mac section, I
think that’s fine. Given the variation in the Linux world, it might even be a
good idea.

Your call.

[sanjeevr, 2011-04-28 22:39:46]

thestig's LGTM for the print related code works for me.