Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 6883217: Fix yasm warnings in libjpeg-turbo. (Closed)

Created:
9 years, 8 months ago by Hironori Bono
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix yasm warnings in libjpeg-turbo. This change fixes all yasm warnings in libjpeg-turbo (section redefinitions and unsupported declarations) so we can compile it without annoying warnings. BUG=none TEST=build libjpeg-turbo without yasm warnings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83312

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -42 lines) Patch
M google.patch View 1 2 3 31 chunks +172 lines, -36 lines 0 comments Download
M simd/jcclrmmx.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jcclrss2.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jcclrss2-64.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jdclrmmx.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jdclrss2.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jdclrss2-64.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jdmrgmmx.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jdmrgss2.asm View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M simd/jdmrgss2-64.asm View 1 chunk +4 lines, -0 lines 0 comments Download
M simd/jsimdext.inc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
9 years, 8 months ago (2011-04-28 04:29:54 UTC) #1
Craig
Can you update google.patch and perhaps README.chromium please? Other than that, it LGTM FWIW.
9 years, 8 months ago (2011-04-28 05:04:28 UTC) #2
Hironori Bono
Greetings, On 2011/04/28 05:04:28, Craig wrote: > Can you update google.patch and perhaps README.chromium please? ...
9 years, 8 months ago (2011-04-28 05:54:24 UTC) #3
Peter Kasting
Is there a way to send this patch upstream so we aren't carrying it locally?
9 years, 8 months ago (2011-04-28 19:49:04 UTC) #4
Hironori Bono
Greetings Peter, Thank you for your suggestion. I have started upstreaming our local changes to ...
9 years, 7 months ago (2011-05-02 10:03:55 UTC) #5
fbarchard
9 years, 7 months ago (2011-05-02 17:14:34 UTC) #6
LGTM++

Powered by Google App Engine
This is Rietveld 408576698