Issue 6883211: Aggregated profiles that contains same name but different casing are being merged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6883211: Aggregated profiles that contains same name but different casing are being merged. (Closed)

Created:
9 years, 8 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, GeorgeY, Paweł Hajdan Jr., Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Aggregated profiles that contains same name but different casing are being merged. Modifies merging logic to treat profile values as case-insensitive for merging purposes. BUG=80618 TEST=AutofillMergeTest.DataDrivenMergeProfiles:case.in/out Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83280

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -2 lines)			Patch
M	chrome/browser/autofill/form_group.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
A	chrome/test/data/autofill/merge/input/case.in	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/test/data/autofill/merge/output/case.out	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages