Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 6883202: audiovideo_V4L2: Added more pixel formats. (Closed)

Created:
9 years, 8 months ago by Andrew Chew
Modified:
9 years, 7 months ago
Reviewers:
zhurunz, jiesun1, jiesun
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

audiovideo_V4L2: Added more pixel formats. Added the rest of the YUYV ordering formats, and also YU12. Change-Id: Id04a780b237c33e985c1750acf36eb925b65b042 BUG=none TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=dfe7f67

Patch Set 1 #

Patch Set 2 : Commonized the various YUYV conversion paths. #

Patch Set 3 : Fixed some indentation inconsistencies. #

Total comments: 5

Patch Set 4 : Applied fixes for all of Jie's nits, and retested all supported formats. #

Patch Set 5 : Fixed a wrongly worded comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -20 lines) Patch
M client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc View 1 2 3 4 1 chunk +97 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Andrew Chew
9 years, 8 months ago (2011-04-27 22:45:39 UTC) #1
jiesun1
LGTM, if you had tested.
9 years, 8 months ago (2011-04-27 22:47:01 UTC) #2
Andrew Chew
I tested YUYV, YVYU, UYVY, and VYUY, and they all look good. I also tested ...
9 years, 8 months ago (2011-04-28 00:03:04 UTC) #3
Andrew Chew
Okay, I think the problem with YU12 right now is in the test. I forced ...
9 years, 8 months ago (2011-04-28 02:56:32 UTC) #4
jiesun
some errors and nits. http://codereview.chromium.org/6883202/diff/3001/client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc File client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc (right): http://codereview.chromium.org/6883202/diff/3001/client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc#newcode158 client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc:158: } I actually prefer to ...
9 years, 8 months ago (2011-04-28 17:28:27 UTC) #5
jiesun
YV12? http://codereview.chromium.org/6883202/diff/3001/client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc File client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc (right): http://codereview.chromium.org/6883202/diff/3001/client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc#newcode181 client/site_tests/audiovideo_V4L2/src/media_v4l2_test.cc:181: } else if (ifmt == v4l2_fourcc('Y', 'U', '1', ...
9 years, 8 months ago (2011-04-28 17:32:31 UTC) #6
Andrew Chew
Done. Retested YUYV, YVYU, UYVY, VYUY, YU12, and YV12, and they all look good.
9 years, 8 months ago (2011-04-28 20:50:07 UTC) #7
jiesun1
9 years, 8 months ago (2011-04-28 21:16:31 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698