This change sorts the members in 'dependencies' section in the order from dependents to dependenc...

This change sorts the members in 'dependencies' section in the order fromdependents to dependencies.

For example, if module A and B depend on C, and module C depends on D, thischange sorts them in the order of [A, B, C, D].

Android NDK's cross-linker requires static libraries to be sorted in thisorder. This change makes it easy to support such tool-chains which require thestrict link order of libraries.

Patch by Yuki Shiino <yukishiino@google.com>;
Committed: http://code.google.com/p/gyp/source/detail?r=922

[Mark Mentovai, 2011-04-26 19:14:24]

LGTM, but I’ll leave the floor open for other commenters in case anyone else has
any thoughts too.

[bradn, 2011-04-26 19:15:43]

LGTM

[Yuki Shiino, 2011-05-03 18:06:00]

On 2011/04/26 19:15:43, bradn wrote:
> LGTM

Could I ask how I can commit this change?

[Evan Martin, 2011-05-03 18:24:08]

On 2011/05/03 18:06:00, Yuki Shiino wrote:
> On 2011/04/26 19:15:43, bradn wrote:
> > LGTM
> 
> Could I ask how I can commit this change?

I will commit it for you.

[Evan Martin, 2011-05-03 18:27:48]

On 2011/05/03 18:24:08, Evan Martin wrote:
> On 2011/05/03 18:06:00, Yuki Shiino wrote:
> > On 2011/04/26 19:15:43, bradn wrote:
> > > LGTM
> > 
> > Could I ask how I can commit this change?
> 
> I will commit it for you.

I applied this patch and ran the test suite but it hit this error:

$ ./gyptest.py -a
PYTHONPATH=/home/evanm/projects/ninja/gyp/test/lib
TESTGYP_FORMAT=make
/usr/bin/python test/actions-bare/gyptest-bare.py
PASSED
/usr/bin/python test/actions-multiple/gyptest-all.py
None returned 1
STDOUT =========================================================================

STDERR =========================================================================
Traceback (most recent call last):
  File "/home/evanm/projects/ninja/gyp/gyp", line 18, in <module>
    sys.exit(gyp.main(sys.argv[1:]))
  File "/home/evanm/projects/ninja/gyp/pylib/gyp/__init__.py", line 445, in main
    options.circular_check)
  File "/home/evanm/projects/ninja/gyp/pylib/gyp/__init__.py", line 84, in Load
    depth, generator_input_info, check, circular_check)
  File "/home/evanm/projects/ninja/gyp/pylib/gyp/input.py", line 2221, in Load
    AdjustStaticLibraryDependencies(flat_list, targets, dependency_nodes)
  File "/home/evanm/projects/ninja/gyp/pylib/gyp/input.py", line 1517, in
AdjustStaticLibraryDependencies
    dep for dep in flat_list if dep in target_dict['dependencies']]
KeyError: 'dependencies'

FAILED test at line 426 of /home/evanm/projects/ninja/gyp/test/lib/TestCommon.py
(_complete)
	from line 543 of /home/evanm/projects/ninja/gyp/test/lib/TestCommon.py (run)
	from line 227 of /home/evanm/projects/ninja/gyp/test/lib/TestGyp.py (run)
	from line 214 of /home/evanm/projects/ninja/gyp/test/lib/TestGyp.py (run_gyp)
	from line 15 of test/actions-multiple/gyptest-all.py

[Yuki Shiino, 2011-05-04 07:57:13]

On 2011/05/03 18:27:48, Evan Martin wrote:
> On 2011/05/03 18:24:08, Evan Martin wrote:
> > On 2011/05/03 18:06:00, Yuki Shiino wrote:
> > > On 2011/04/26 19:15:43, bradn wrote:
> > > > LGTM
> > > 
> > > Could I ask how I can commit this change?
> > 
> > I will commit it for you.
> 
> I applied this patch and ran the test suite but it hit this error:
> 
> $ ./gyptest.py -a
> PYTHONPATH=/home/evanm/projects/ninja/gyp/test/lib
> TESTGYP_FORMAT=make
> /usr/bin/python test/actions-bare/gyptest-bare.py
> PASSED
> /usr/bin/python test/actions-multiple/gyptest-all.py
> None returned 1
> STDOUT
=========================================================================
> 
> STDERR
=========================================================================
> Traceback (most recent call last):
>   File "/home/evanm/projects/ninja/gyp/gyp", line 18, in <module>
>     sys.exit(gyp.main(sys.argv[1:]))
>   File "/home/evanm/projects/ninja/gyp/pylib/gyp/__init__.py", line 445, in
main
>     options.circular_check)
>   File "/home/evanm/projects/ninja/gyp/pylib/gyp/__init__.py", line 84, in
Load
>     depth, generator_input_info, check, circular_check)
>   File "/home/evanm/projects/ninja/gyp/pylib/gyp/input.py", line 2221, in Load
>     AdjustStaticLibraryDependencies(flat_list, targets, dependency_nodes)
>   File "/home/evanm/projects/ninja/gyp/pylib/gyp/input.py", line 1517, in
> AdjustStaticLibraryDependencies
>     dep for dep in flat_list if dep in target_dict['dependencies']]
> KeyError: 'dependencies'
> 
> FAILED test at line 426 of
/home/evanm/projects/ninja/gyp/test/lib/TestCommon.py
> (_complete)
> 	from line 543 of /home/evanm/projects/ninja/gyp/test/lib/TestCommon.py (run)
> 	from line 227 of /home/evanm/projects/ninja/gyp/test/lib/TestGyp.py (run)
> 	from line 214 of /home/evanm/projects/ninja/gyp/test/lib/TestGyp.py (run_gyp)
> 	from line 15 of test/actions-multiple/gyptest-all.py

Sorry for the careless mistake.
I've added a check if the key 'dependencies' exists or not.

[Mark Mentovai, 2011-05-05 14:54:31]

Committed as r922.