net/http/http_cache_transaction.cc - Issue 6883102: Add one-time randomization support for FieldTrial, and the ability to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.cc

Issue 6883102: Add one-time randomization support for FieldTrial, and the ability to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Responding to review comments. Fix initialization in browser_main. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_transaction.cc

diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc

index a12a64fcdd4fae2a269846457fd209b31de645aa..6f39fee4b4ac087ba692d7f5aee978fa4b5e24ae 100644

--- a/net/http/http_cache_transaction.cc

+++ b/net/http/http_cache_transaction.cc

@@ -859,8 +859,7 @@ int HttpCache::Transaction::DoAddToEntryComplete(int result) {

base::TimeTicks::Now() - entry_lock_waiting_since_;

UMA_HISTOGRAM_TIMES("HttpCache.EntryLockWait", entry_lock_wait);

static const bool prefetching_fieldtrial =

- base::FieldTrialList::Find("Prefetch") &&

- !base::FieldTrialList::Find("Prefetch")->group_name().empty();

+ base::FieldTrialList::TrialExists("Prefetch");

if (prefetching_fieldtrial) {

UMA_HISTOGRAM_TIMES(

base::FieldTrial::MakeName("HttpCache.EntryLockWait", "Prefetch"),