base/metrics/OWNERS - Issue 6883102: Add one-time randomization support for FieldTrial, and the ability to

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/metrics/OWNERS

Issue 6883102: Add one-time randomization support for FieldTrial, and the ability to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 jar@chromium.org
	wtc 2011/05/04 17:58:05 jar: to require owners' approval, you need to add jar: to require owners' approval, you need to add set noparent to this file. Jói 2011/05/04 20:02:09 My intent was that jar@ or anybody in base/OWNERS Show quoted text On 2011/05/04 17:58:05, wtc wrote: > jar: to require owners' approval, you need to add > set noparent > to this file. My intent was that jar@ or anybody in base/OWNERS could approve changes in base/metrics. base/OWNERS already has "set noparent" so the approval would (if I understand correctly) be forced, just not limited to only jar@. Jim, let me know if you would prefer "set noparent" here and I can add it before I commit. Mark Mentovai 2011/05/04 20:21:24 Please don’t “set noparent” any OWNERS file that h Please don’t “set noparent” any OWNERS file that has only one OWNER.
OLD	NEW

« no previous file with comments | « no previous file | base/metrics/field_trial.h » ('j') | base/rand_util.h » ('J')