Issue 6883093: Leak in FSMoveObjectToTrashSync on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6883093: Leak in FSMoveObjectToTrashSync on Mac (Closed)

Created:
9 years, 8 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Leak in FSMoveObjectToTrashSync on Mac Expand leak in FSMoveObjectToTrashSync on Mac to account for TaskClosureAdapter changes in r82300. BUG=77063 TEST=Valgrind bots on Mac go green. TBR=ajwong@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82353

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

9 years, 8 months ago (2011-04-25 07:03:49 UTC) #2

LGTM

Ugh...guess I missed one. Thanks for fixing!

On Thu, Apr 21, 2011 at 4:40 AM, <dhollowa@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Leak in FSMoveObjectToTrashSync on Mac
>
> Expand leak in FSMoveObjectToTrashSync on Mac to account for
> TaskClosureAdapter
> changes in r82300.
>
> BUG=77063
> TEST=Valgrind bots on Mac go green.
> TBR=ajwong@chromium.org
>
>
> Please review this at http://codereview.chromium.org/6883093/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions_mac.txt
>
>
> Index: tools/valgrind/memcheck/suppressions_mac.txt
> diff --git a/tools/valgrind/memcheck/suppressions_mac.txt
> b/tools/valgrind/memcheck/suppressions_mac.txt
> index
>
de60db65978d049bdf89da6b72f4827213e518d8..4cc1b80a6e2d90eb46b2f060ad28d0c47d50b8da
> 100644
> --- a/tools/valgrind/memcheck/suppressions_mac.txt
> +++ b/tools/valgrind/memcheck/suppressions_mac.txt
> @@ -1454,7 +1454,6 @@
>    fun:_Z9TrashFuncRK8FilePath
>    fun:_Z18DispatchToFunctionIPFvRK8FilePathES0_EvT_RK6Tuple1IT0_E
>    fun:_ZN16RunnableFunctionIPFvRK8FilePathE6Tuple1IS0_EE3RunEv
> -   fun:_ZN11MessageLoop7RunTaskEP4Task
>  }
>  {
>    bug_77265_a
>
>
>

Expand Messages | Collapse Messages