Pass relative paths to GIT.CaptureStatus

Pass relative paths to GIT.CaptureStatus

BUG=79953
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82290

[Bernhard Bauer, 2011-04-20 14:46:08]

Please review.

[M-A Ruel, 2011-04-20 14:50:06]

lgtm, thanks

http://codereview.chromium.org/6883085/diff/1/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/6883085/diff/1/git_cl.py#newcode521
git_cl.py:521: files = scm.GIT.CaptureStatus([root], upstream_branch)
Can you note that
# It must not be abspath because of msysgit.

[commit-bot: I haz the power, 2011-04-20 15:08:53]

Presubmit check for 6883085-2003 failed and returned exit status 1.

Running presubmit commit checks ...
Syncing rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running tbr.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
tests/gclient_scm_test.py failed!
Command tests/gclient_scm_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/depot_tools
...........EE...................
======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 757, in testUpdateUnstagedConflict
    scm.update(options, (), [])
  File "/mnt/data/b/commit-queue/workdir/depot_tools/gclient_scm.py", line 393,
in update
    raise gclient_utils.Error(e.stderr)
Error: error: Your local changes to 'b' would be overwritten by merge. 
Aborting.
Please, commit your changes or stash them before you can merge.


======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 539, in tearDown
    StdoutCheck.tearDown(self)
  File "/mnt/data/b/commit-queue/workdir/depot_tools/tests/super_mox.py", line
100, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != '\n_____ . at refs/heads/master\n'

----------------------------------------------------------------------
Ran 31 tests in 1.513s

FAILED (errors=2)


upstream.sh failed
Command /mnt/data/b/commit-queue/workdir/depot_tools/tests/upstream.sh returned
non-zero exit status 1 in /mnt/data/b/commit-queue/workdir/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
error: unknown switch `B'
usage: git checkout [options] <branch>
   or: git checkout [options] [<branch>] -- <file>...

    -q, --quiet           be quiet
    -b <new branch>       branch
    -l                    log for new branch
    -t, --track           track
    -2, --ours            stage
    -3, --theirs          stage
    -f, --force           force
    -m, --merge           merge
    --conflict <style>    conflict style (merge or diff3)
    -p, --patch           select hunks interactively



Presubmit checks took 265.9s to calculate.

[M-A Ruel, 2011-04-20 15:15:26]

On 2011/04/20 15:08:53, commit-bot wrote:
> Presubmit check for 6883085-2003 failed and returned exit status 1.

Yeah I know, a shame. :D

Just commit manually.