Issue 6883065: make: Expose a 'linker_supports_icf' flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6883065: make: Expose a 'linker_supports_icf' flag. (Closed)

Created:
9 years, 8 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, tony

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Description

make: Expose a 'linker_supports_icf' flag. This will allow us to use the flag in some build configurations of Chrome. Committed: http://code.google.com/p/gyp/source/detail?r=914

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	pylib/gyp/generator/make.py	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
	M	pylib/gyp/system_test.py	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM, although it feels a bit magical to me. Do we care that someone else ...

9 years, 8 months ago (2011-04-19 22:52:29 UTC) #2

Evan Martin

9 years, 8 months ago (2011-04-21 19:18:46 UTC) #3

Mark, do you have any thoughts about Tony's objection?  It does seem gyp has
explicit provisions for generators to add variables, but perhaps there's a
convention I should be following?

Expand Messages | Collapse Messages