presubmit checks: skip computing the diff if possible

tests/presubmit_unittest.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 # pylint is too confused.
 # pylint: disable=E1101,E1103,R0201,W0212,W0403
 
@@ skipping 1356 matching lines @@
     input_api2 = self.MockInputApi(change2, committing)
     self.mox.ReplayAll()
 
     results1 = check(input_api1, presubmit.OutputApi)
     self.assertEquals(results1, [])
     results2 = check(input_api2, presubmit.OutputApi)
     self.assertEquals(len(results2), 1)
     self.assertEquals(results2[0].__class__, error_type)
 
   def ContentTest(self, check, content1, content2, error_type):
+    """Runs a test of a content-checking rule.
+
+      Args:
+        check: the check to run.
+        content1: content which is expected to pass the check.
+        content2: content which is expected to fail the check.
+        error_type: the type of the error expected for content2.
+    """
     change1 = presubmit.Change(
         'foo1', 'foo1\n', self.fake_root_dir, None, 0, 0, None)
     input_api1 = self.MockInputApi(change1, False)
     affected_file = self.mox.CreateMock(presubmit.SvnAffectedFile)
-    affected_file.LocalPath().AndReturn('foo.cc')
-    # Format is (file, line number, line content)
-    output1 = [
-      (affected_file, 42, 'yo, ' + content1),
-      (affected_file, 43, 'yer'),
-      (affected_file, 23, 'ya'),
-    ]
-    input_api1.RightHandSideLines(mox.IgnoreArg()).AndReturn(output1)
+    input_api1.AffectedFiles(mox.IgnoreArg(), include_deletes=False).AndReturn(
+        [affected_file])
+    affected_file.NewContents().AndReturn([
+        'ahoy',
+        'yo' + content1,
+        'hay',
+        'yer',
+        'ya'])
+
     change2 = presubmit.Change(
         'foo2', 'foo2\n', self.fake_root_dir, None, 0, 0, None)
     input_api2 = self.MockInputApi(change2, False)
-    output2 = [
-      (affected_file, 42, 'yo, ' + content2),
-      (affected_file, 43, 'yer'),
-      (affected_file, 23, 'ya'),
-    ]
-    input_api2.RightHandSideLines(mox.IgnoreArg()).AndReturn(output2)
+
+    input_api2.AffectedFiles(mox.IgnoreArg(), include_deletes=False).AndReturn(
+        [affected_file])
+    affected_file.NewContents().AndReturn([
+        'ahoy',
+        'yo' + content2,
+        'hay',
+        'yer',
+        'ya'])
+    affected_file.ChangedContents().AndReturn([
+        (42, 'yo, ' + content2),
+        (43, 'yer'),
+        (23, 'ya')])
+    affected_file.LocalPath().AndReturn('foo.cc')
+
     self.mox.ReplayAll()
 
     results1 = check(input_api1, presubmit.OutputApi, None)
     self.assertEquals(results1, [])
     results2 = check(input_api2, presubmit.OutputApi, None)
     self.assertEquals(len(results2), 1)
     self.assertEquals(results2[0].__class__, error_type)
 
   def ReadFileTest(self, check, content1, content2, error_type):
     self.mox.StubOutWithMock(presubmit.InputApi, 'ReadFile')
@@ skipping 150 matching lines @@
     input_api1 = self.MockInputApi(change1, False)
     affected_file1 = self.mox.CreateMock(presubmit.SvnAffectedFile)
     affected_file1.LocalPath().AndReturn('foo.cc')
     affected_file2 = self.mox.CreateMock(presubmit.SvnAffectedFile)
     affected_file2.LocalPath().AndReturn('foo/Makefile')
     affected_file3 = self.mox.CreateMock(presubmit.SvnAffectedFile)
     affected_file3.LocalPath().AndReturn('makefile')
     # Only this one will trigger.
     affected_file4 = self.mox.CreateMock(presubmit.SvnAffectedFile)
     affected_file4.LocalPath().AndReturn('makefile.foo')
+    affected_file1.NewContents().AndReturn(['yo, '])
+    affected_file4.NewContents().AndReturn(['ye\t'])
+    affected_file4.ChangedContents().AndReturn([(46, 'ye\t')])
     affected_file4.LocalPath().AndReturn('makefile.foo')
-    output1 = [
-      (affected_file1, 42, 'yo, '),
-      (affected_file2, 43, 'yer\t'),
-      (affected_file3, 45, 'yr\t'),
-      (affected_file4, 46, 'ye\t'),
-    ]
-    def test(source_filter):
-      for i in output1:
-        if source_filter(i[0]):
-          yield i
+    affected_files = (affected_file1, affected_file2,
+                      affected_file3, affected_file4)
+
+    def test(source_filter, include_deletes):
+      self.assertFalse(include_deletes)
+      for x in affected_files:
+        if source_filter(x):
+          yield x
     # Override the mock of these functions.
     input_api1.FilterSourceFile = lambda x: x
-    input_api1.RightHandSideLines = test
+    input_api1.AffectedFiles = test
     self.mox.ReplayAll()
 
     results1 = presubmit_canned_checks.CheckChangeHasNoTabs(input_api1,
         presubmit.OutputApi, None)
     self.assertEquals(len(results1), 1)
     self.assertEquals(results1[0].__class__,
         presubmit.OutputApi.PresubmitPromptWarning)
     self.assertEquals(results1[0]._long_text,
         'makefile.foo, line 46')
 
@@ skipping 527 matching lines @@
         whitelist=['^a$', '^b$'],
         blacklist=['a'])
     self.assertEqual(results, [])
     self.checkstdout(
         'Running %s\n' % presubmit.os.path.join('random_directory', 'b'))
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()