Issue 6883048: Activate buildbot, lucid64-pnacl2, for pnacl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6883048: Activate buildbot, lucid64-pnacl2, for pnacl. (Closed)

Created:
9 years, 8 months ago by robertm

Modified:
9 years, 7 months ago

Reviewers:
pdox, bradn, jvoung - send to chromium...

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Description

Activate buildbot, lucid64-pnacl2, for pnacl. Before it was just running a nacl-gcc tests. Also, change task assignement as follow to reduce bot running time: lucid64-pnacl1 x86-32 only lucid64-pnacl2 x86-64 only BUG= http://code.google.com/p/nativeclient/issues/detail?id=1647 Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4930

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -18 lines)			Patch
	M	buildbot/buildbot_pnacl1.sh	View	1 2	4 chunks	+31 lines, -16 lines	0 comments	Download
	M	buildbot/buildbot_selector.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jvoung - send to chromium...

9 years, 8 months ago (2011-04-19 16:46:14 UTC) #2

LGTM, some other quote fixups suggested

http://codereview.chromium.org/6883048/diff/4/buildbot/buildbot_pnacl1.sh
File buildbot/buildbot_pnacl1.sh (right):

http://codereview.chromium.org/6883048/diff/4/buildbot/buildbot_pnacl1.sh#new...
buildbot/buildbot_pnacl1.sh:63: echo @@@BUILD_STEP gyp_compile@@@
Can add quotes here and for gyp_tests also.

http://codereview.chromium.org/6883048/diff/4/buildbot/buildbot_pnacl1.sh#new...
buildbot/buildbot_pnacl1.sh:93: (RETCODE=$? && echo @@@STEP_FAILURE@@@)
can add quotes for the @@@ here too

Expand Messages | Collapse Messages