Print Preview: Do not show an invalid summary on load and remove the "no printers" UI code.

chrome/browser/resources/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
 var hasPDFPlugin = true;
 var expectedPageCount = 0;
 var pageRangesInfo = [];
 var printJobTitle = '';
 
 /**
  * Window onload handler, sets up the page.
  */
 function load() {
   initializeAnimation();
 
-  updateSummary();
-
   $('printer-list').disabled = true;
   $('print-button').disabled = true;
   $('print-button').addEventListener('click', printFile);
   $('cancel-button').addEventListener('click', function(e) {
     window.close();
   });
 
   $('copies').addEventListener('input', validateNumberOfCopies);
   $('copies').addEventListener('blur', handleCopiesFieldBlur);
   $('individual-pages').addEventListener('blur', handlePageRangesFieldBlur);
@@ skipping 86 matching lines @@
   var pageRanges = getPageRanges();
   var parsedPageRanges = '';
   var individualPagesField = $('individual-pages');
 
   if (pageRanges.length == 1 && pageRanges[0].from == 1 &&
           pageRanges[0].to == expectedPageCount) {
     individualPagesField.value = parsedPageRanges;
     return;
   }
 
-  for (var i = 0; i < pageRanges.length; i++) {
+  for (var i = 0; i < pageRanges.length; ++i) {

[Lei Zhang, 2011/04/19 01:29:17]

There's no rule for this in JS, but I'd like to do this to be consistent, both
in the file itself and with C++ code.

     if (pageRanges[i].from == pageRanges[i].to)
       parsedPageRanges += pageRanges[i].from;
     else
       parsedPageRanges += pageRanges[i].from + '-' + pageRanges[i].to;
     if (i < pageRanges.length - 1)
       parsedPageRanges += ', ';
   }
   individualPagesField.value = parsedPageRanges;
   updateSummary();
 }
@@ skipping 86 matching lines @@
 function getPreview() {
   chrome.send('getPreview', [getSettingsJSON()]);
 }
 
 /**
  * Fill the printer list drop down.
  * @param {Array} printers Array of printer names.
  * @param {number} defaultPrinterIndex The index of the default printer.
  */
 function setPrinters(printers, defaultPrinterIndex) {
-  if (printers.length > 0) {
-    for (var i = 0; i < printers.length; ++i) {
-      var option = document.createElement('option');
-      option.textContent = printers[i];
-      $('printer-list').add(option);
-      if (i == defaultPrinterIndex)
-        option.selected = true;
-    }
-  } else {
+  var printerList = $('printer-list');
+  for (var i = 0; i < printers.length; ++i) {
     var option = document.createElement('option');

[dpapad, 2011/04/19 01:50:36]

Removing the "No printer found" is ok with me, since there is always going to be
at least one option. The idea behind that was to at least let the user know that
Chrome searched for any printers.

-    option.textContent = localStrings.getString('noPrinter');
-    $('printer-list').add(option);
+    option.textContent = printers[i];
+    printerList.add(option);
+    if (i == defaultPrinterIndex)
+      option.selected = true;
   }
 
   // Adding option for saving PDF to disk.
   var option = document.createElement('option');
   option.textContent = localStrings.getString('printToPDF');
-  $('printer-list').add(option);
-  $('printer-list').disabled = false;
+  printerList.add(option);
+  printerList.disabled = false;
 
   // Once the printer list is populated, generate the initial preview.
   getPreview();
 }
 
 /**
  * Sets the color mode for the PDF plugin.
  * @param {boolean} color is true if the PDF plugin should display in color.
  */
 function setColor(color) {
@@ skipping 194 matching lines @@
  */
 function getPageList() {
   var pageText = $('individual-pages').value;
 
   if ($('all-pages').checked || pageText == '')
     pageText = '1-' + expectedPageCount;
 
   var pageList = [];
   var parts = pageText.split(/,/);
 
-  for (var i = 0; i < parts.length; i++) {
+  for (var i = 0; i < parts.length; ++i) {
     var part = parts[i];
     var match = part.match(/([0-9]+)-([0-9]+)/);
 
     if (match && match[1] && match[2]) {
       var from = parseInt(match[1], 10);
       var to = parseInt(match[2], 10);
 
       if (from && to) {
-        for (var j = from; j <= to; j++)
+        for (var j = from; j <= to; ++j)
           if (j <= expectedPageCount)
             pageList.push(j);
       }
     } else if (parseInt(part, 10)) {
       if (parseInt(part, 10) <= expectedPageCount)
         pageList.push(parseInt(part, 10));
     }
   }
   return pageList;
 }
 
 /**
  * Parses the selected page ranges, processes them and returns the results.
  * It squashes whenever possible. Example '1-2,3,5-7' becomes 1-3,5-7
  *
  * @return {Array} an array of page range objects. A page range object has
  *     fields 'from' and 'to'.
  */
 function getPageRanges() {
   var pageList = getPageList();
   var pageRanges = [];
-  for (var i = 0; i < pageList.length; i++) {
+  for (var i = 0; i < pageList.length; ++i) {
     tempFrom = pageList[i];
     while (i + 1 < pageList.length && pageList[i + 1] == pageList[i] + 1)
-      i++;
+      ++i;
     tempTo = pageList[i];
     pageRanges.push({'from': tempFrom, 'to': tempTo});
   }
   return pageRanges;
 }