Issue 6883020: Make icon_messages use the IPC macros for defining the structs and the serialization code, and mo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6883020: Make icon_messages use the IPC macros for defining the structs and the serialization code, and mo... (Closed)

Created:
9 years, 8 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
michaelbai

CC:
chromium-reviews, Avi (use Gerrit), tburkard+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make icon_messages use the IPC macros for defining the structs and the serialization code, and move the icon messages there. Also get rid of friend class in RenderView that's not needed anymore. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81999

Patch Set 1 : '' #

Patch Set 2 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -209 lines)			Patch
M	chrome/browser/favicon_helper.h	View		2 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/favicon_helper.cc	View		8 chunks	+45 lines, -30 lines	0 comments	Download
M	chrome/browser/favicon_helper_unittest.cc	View	1	15 chunks	+30 lines, -28 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/common_message_generator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/common/favicon_url.h	View		1 chunk	+32 lines, -0 lines	0 comments	Download
A	chrome/common/favicon_url.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/common/icon_messages.h	View		1 chunk	+29 lines, -41 lines	0 comments	Download
D	chrome/common/icon_messages.cc	View		1 chunk	+0 lines, -60 lines	0 comments	Download
M	chrome/common/render_messages.h	View		4 chunks	+0 lines, -21 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View		6 chunks	+9 lines, -8 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/renderer/render_view.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ipc/ipc_message_utils.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks for making this change

Expand Messages | Collapse Messages