Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3352)

Unified Diff: checkout.py

Issue 6882127: Make subprocess2.check_call() compliant with subprocess.check_call(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | subprocess2.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: checkout.py
diff --git a/checkout.py b/checkout.py
index fcdea220a2373df292ff5502e035738789fc5e9c..9abd92510d81c567466d3b39454e333f04d59374 100644
--- a/checkout.py
+++ b/checkout.py
@@ -183,7 +183,8 @@ class SvnMixIn(object):
"""Runs svn and throws an exception if the command failed."""
kwargs.setdefault('cwd', self.project_path)
kwargs.setdefault('stdout', self.VOID)
- return subprocess2.check_call(self._add_svn_flags(args, False), **kwargs)
+ return subprocess2.check_call_out(
+ self._add_svn_flags(args, False), **kwargs)
def _check_output_svn(self, args, **kwargs):
"""Runs svn and throws an exception if the command failed.
@@ -412,7 +413,7 @@ class GitCheckoutBase(CheckoutBase):
def _check_call_git(self, args, **kwargs):
kwargs.setdefault('cwd', self.project_path)
kwargs.setdefault('stdout', self.VOID)
- return subprocess2.check_call(['git'] + args, **kwargs)
+ return subprocess2.check_call_out(['git'] + args, **kwargs)
def _call_git(self, args, **kwargs):
"""Like check_call but doesn't throw on failure."""
« no previous file with comments | « no previous file | subprocess2.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698