Issue 6882108: Revert 82405 - Support more than 9 arguments for ReplaceStringPlaceholders()- support more than 9...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6882108: Revert 82405 - Support more than 9 arguments for ReplaceStringPlaceholders()- support more than 9... (Closed)

Created:
9 years, 8 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
tony, haraken1

CC:
chromium-reviews, brettw-cc_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 82405 - Support more than 9 arguments for ReplaceStringPlaceholders()- support more than 9 arguments ($1, $2, $3, ..., $9 and $10, $11, $12, ...) for ReplaceStringPlaceholders()- add the unittest named ReplaceStringPlaceholdersMoreThan9Replacements for testing more than 9 arguments for ReplaceStringPlaceholders()BUG=16963 TEST=string_util_unittest:StringUtilTest.ReplaceStringPlaceholdersMoreThan9ReplacementsPatch by haraken@google.com.Review URL: http://codereview.chromium.org/6877008 TBR=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82423

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -40 lines)			Patch
	M	base/string_util.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
	M	base/string_util_unittest.cc	View		3 chunks	+6 lines, -32 lines	0 comments	Download

Total messages: 2 (0 generated)

LG