Wrap the p2p transport API in a compile time flag.

Wrap the p2p transport API in a compile time flag.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82295

[Sergey Ulanov, 2011-04-18 20:27:26]

You will also need to add ifdefs around code that depends on P2P code you
disabled. Particularly in 
 content/renderer/render_view.cc,
 chrome/browser/renderer_host/browser_render_process_host.cc,
 content/renderer/pepper_plugin_delegate_impl.cc.
Other than that it looks good.

[Satish, 2011-04-19 11:26:56]

New patch uploaded disabling more code as suggested if the p2p api was not
enabled at compile time.

[Sergey Ulanov, 2011-04-19 18:54:57]

+brettw, to review/approve ppapi changes

http://codereview.chromium.org/6882021/diff/2009/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/6882021/diff/2009/build/common.gypi#newcode133
build/common.gypi:133: 'ppapi_transport%': 1,
It might be better to call it p2papi or p2p_apis to be consistent with the
command line flag, and because it affects not only ppapi, but will also RTC
APIs. Also please add comment saying that it must be enabled if remoting is
enabled.

http://codereview.chromium.org/6882021/diff/2009/webkit/glue/webkit_glue.gypi
File webkit/glue/webkit_glue.gypi (right):

http://codereview.chromium.org/6882021/diff/2009/webkit/glue/webkit_glue.gypi...
webkit/glue/webkit_glue.gypi:506: 'p2p_transport.h',
Not that it metters much, but I think it's better to keep this header always
enabled - it's included in other files anyway.

[Sergey Ulanov, 2011-04-19 20:03:41]

LGTM.

[Satish, 2011-04-20 06:55:27]

Hi Brett, could you please have a look and if look ok approve the changes under
content/ ?

[brettw, 2011-04-20 15:41:33]

LGTM with some minor moving of ifdefed code.

http://codereview.chromium.org/6882021/diff/31/content/common/content_switche...
File content/common/content_switches.cc (right):

http://codereview.chromium.org/6882021/diff/31/content/common/content_switche...
content/common/content_switches.cc:145: #if defined(ENABLE_P2P_APIS)
Please put ifdefed stuff at the bottom of the file.

http://codereview.chromium.org/6882021/diff/31/content/common/content_switches.h
File content/common/content_switches.h (right):

http://codereview.chromium.org/6882021/diff/31/content/common/content_switche...
content/common/content_switches.h:53: #if defined(ENABLE_P2P_APIS)
Please put ifdefed stuff at the bottom.

http://codereview.chromium.org/6882021/diff/31/webkit/plugins/ppapi/plugin_mo...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/6882021/diff/31/webkit/plugins/ppapi/plugin_mo...
webkit/plugins/ppapi/plugin_module.cc:295: #if defined(ENABLE_P2P_APIS)
Please put this at the bottom as well with the other ifdefs.

[Satish, 2011-04-20 15:49:12]

Thanks, will submit after making these changes.