Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: views/widget/native_widget_test_utils_gtk.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/widget/native_widget_test_utils_gtk.cc
===================================================================
--- views/widget/native_widget_test_utils_gtk.cc (revision 82649)
+++ views/widget/native_widget_test_utils_gtk.cc (working copy)
@@ -5,7 +5,7 @@
#include "views/widget/native_widget_test_utils.h"
#include "views/view.h"
-#include "views/widget/widget_gtk.h"
+#include "views/widget/widget.h"
namespace views {
namespace internal {
@@ -15,18 +15,22 @@
}
NativeWidget* CreateNativeWidgetWithContents(View* contents_view) {
- WidgetGtk* widget = new WidgetGtk(WidgetGtk::TYPE_WINDOW);
- widget->set_delete_on_destroy(false);
- widget->Init(NULL, gfx::Rect(10, 10, 200, 200));
- return widget;
+ Widget* widget = Widget::CreateWidget();
+ Widget::CreateParams params(Widget::CreateParams::TYPE_WINDOW);
+ params.delete_on_destroy = false;
+ params.bounds = gfx::Rect(10, 10, 200, 200);
+ widget->Init(params);
+ return widget->native_widget();
}
NativeWidget* CreateNativeWidgetWithParent(NativeWidget* parent) {
- WidgetGtk* widget = new WidgetGtk(WidgetGtk::TYPE_CHILD);
- widget->set_delete_on_destroy(false);
- widget->Init(parent ? parent->GetWidget()->GetNativeView() : NULL,
- gfx::Rect(10, 10, 200, 200));
- return widget;
+ Widget* widget = Widget::CreateWidget();
+ Widget::CreateParams params(Widget::CreateParams::TYPE_CONTROL);
+ params.delete_on_destroy = false;
+ params.parent = parent ? parent->GetWidget()->GetNativeView() : NULL;
+ params.bounds = gfx::Rect(10, 10, 200, 200);
+ widget->Init(params);
+ return widget->native_widget();
}
} // namespace internal

Powered by Google App Engine
This is Rietveld 408576698