Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3698)

Unified Diff: chrome/browser/ui/views/fullscreen_exit_bubble.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/fullscreen_exit_bubble.cc
===================================================================
--- chrome/browser/ui/views/fullscreen_exit_bubble.cc (revision 82649)
+++ chrome/browser/ui/views/fullscreen_exit_bubble.cc (working copy)
@@ -131,13 +131,15 @@
this, UTF16ToWideHack(accelerator.GetShortcutText()));
// Initialize the popup.
+ popup_ = views::Widget::CreateWidget();
+ popup_->SetOpacity(static_cast<unsigned char>(0xff * kOpacity));
views::Widget::CreateParams params(views::Widget::CreateParams::TYPE_POPUP);
params.transparent = true;
params.can_activate = false;
params.delete_on_destroy = false;
- popup_ = views::Widget::CreateWidget(params);
- popup_->SetOpacity(static_cast<unsigned char>(0xff * kOpacity));
- popup_->Init(frame->GetNativeView(), GetPopupRect(false));
+ params.parent = frame->GetNativeView();
+ params.bounds = GetPopupRect(false);
+ popup_->Init(params);
popup_->SetContentsView(view_);
popup_->Show(); // This does not activate the popup.

Powered by Google App Engine
This is Rietveld 408576698