Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/chromeos/login/message_bubble.cc

Issue 6881107: Rework the way Widget::Init works: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/message_bubble.cc
===================================================================
--- chrome/browser/chromeos/login/message_bubble.cc (revision 82649)
+++ chrome/browser/chromeos/login/message_bubble.cc (working copy)
@@ -20,14 +20,13 @@
static const int kBorderSize = 4;
static const int kMaxLabelWidth = 250;
-MessageBubble::MessageBubble(views::WidgetGtk::Type type,
- views::Widget* parent,
+MessageBubble::MessageBubble(views::Widget* parent,
SkBitmap* image,
const std::wstring& text,
const std::wstring& help,
bool grab_enabled,
MessageBubbleDelegate* delegate)
- : Bubble(type, false), // don't show while screen is locked
+ : Bubble(false), // don't show while screen is locked
parent_(parent),
help_link_(NULL),
message_delegate_(delegate),
@@ -112,8 +111,8 @@
const std::wstring& help,
MessageBubbleDelegate* delegate) {
// The bubble will be destroyed when it is closed.
- MessageBubble* bubble = new MessageBubble(
- views::WidgetGtk::TYPE_WINDOW, parent, image, text, help, true, delegate);
+ MessageBubble* bubble = new MessageBubble(parent, image, text, help, true,
+ delegate);
bubble->InitBubble(parent, position_relative_to, arrow_location,
bubble->text_->parent(), delegate);
return bubble;
@@ -129,8 +128,8 @@
const std::wstring& help,
MessageBubbleDelegate* delegate) {
// The bubble will be destroyed when it is closed.
- MessageBubble* bubble = new MessageBubble(
- views::WidgetGtk::TYPE_CHILD, parent, image, text, help, false, delegate);
+ MessageBubble* bubble = new MessageBubble(parent, image, text, help, false,
+ delegate);
bubble->InitBubble(parent, position_relative_to, arrow_location,
bubble->text_->parent(), delegate);
return bubble;

Powered by Google App Engine
This is Rietveld 408576698