Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: net/url_request/url_request_job.cc

Issue 6881106: Treat ERR_CONNECTION_CLOSED as end-of-data marker for downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved detection code to URLRequestHttpJob. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job.cc
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 3073414d421426aa7e3b086300840e6069007db1..6235ed6f112c7d8406ca4ddb19faa2b56a1aedef 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -306,7 +306,7 @@ void URLRequestJob::NotifyReadComplete(int bytes_read) {
return;
// When notifying the delegate, the delegate can release the request
- // (and thus release 'this'). After calling to the delgate, we must
+ // (and thus release 'this'). After calling to the delegate, we must
// check the request pointer to see if it still exists, and return
// immediately if it has been destroyed. self_preservation ensures our
// survival until we can get out of this method.
@@ -327,6 +327,10 @@ void URLRequestJob::NotifyReadComplete(int bytes_read) {
postfilter_bytes_read_ += bytes_read;
request_->delegate()->OnReadCompleted(request_, bytes_read);
}
+ VLOG(1) << __FUNCTION__ << "() "
+ << "\"" << (request_ ? request_->url().spec() : "???") << "\""
+ << " bytes read = " << bytes_read
+ << " total = " << postfilter_bytes_read_;
Randy Smith (Not in Mondays) 2011/05/03 21:30:41 This seems way too chatty; if someone does --v=1,
ahendrickson 2011/05/04 15:08:25 Oops, that was an oversight. Changed it to VLOG(2
}
void URLRequestJob::NotifyStartError(const URLRequestStatus &status) {
« net/url_request/url_request_http_job.cc ('K') | « net/url_request/url_request_http_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698