Treat ERR_CONNECTION_CLOSED as end-of-data marker for downloads.

net/url_request/url_request_http_job.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
@@ skipping 265 matching lines @@
   // notified of the headers completion so that we can update the cookie store.
   if (transaction_->IsReadyToRestartForAuth()) {
     DCHECK(!response_info_->auth_challenge.get());
     RestartTransactionWithAuth(string16(), string16());
     return;
   }
 
   URLRequestJob::NotifyHeadersComplete();
 }
 
-void URLRequestHttpJob::NotifyDone(const URLRequestStatus& status) {
+void URLRequestHttpJob::NotifyDone(const URLRequestStatus& original_status) {
+  URLRequestStatus status(original_status);
+  // Some servers send the body compressed, but specify the content length as
+  // the uncompressed size.  Although this violates the HTTP spec we want to
+  // support it (as IE and FireFox do), but *only* for an exact match.
+  // See http://crbug.com/79694.
+  if (status.os_error() == net::ERR_CONNECTION_CLOSED) {
+    if (request_ && request_->response_headers()) {
+      int64 expected_length = request_->response_headers()->GetContentLength();
+      VLOG(21) << __FUNCTION__ << "() "
+               << "\"" << request_->url().spec() << "\""
+               << " content-length = " << expected_length
+               << " pre total = " << prefilter_bytes_read()
+               << " post total = " << postfilter_bytes_read();
+      if (0 == expected_length ||
+          postfilter_bytes_read() == expected_length ||
+          prefilter_bytes_read() == expected_length) {

[rvargas (doing something else), 2011/05/19 19:30:36]

if expected_length is 0 or prefilter_bytes_read we should not be clearing the
error, because those conditions should not be generating the error in the first
place (or at least not the one that we want to mask).

[ahendrickson, 2011/05/19 22:29:34]

Done.

+        // Clear the error.
+        status = URLRequestStatus();
+      }
+    }
+  }
+
   RecordCompressionHistograms();
   URLRequestJob::NotifyDone(status);
 }
 
 void URLRequestHttpJob::DestroyTransaction() {
   DCHECK(transaction_.get());
 
   transaction_.reset();
   response_info_ = NULL;
   context_ = NULL;
@@ skipping 1072 matching lines @@
 }
 
 bool URLRequestHttpJob::IsCompressibleContent() const {
   std::string mime_type;
   return GetMimeType(&mime_type) &&
       (IsSupportedJavascriptMimeType(mime_type.c_str()) ||
        IsSupportedNonImageMimeType(mime_type.c_str()));
 }
 
 }  // namespace net