Treat ERR_CONNECTION_CLOSED as end-of-data marker for downloads.

net/http/http_stream_parser.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_parser.h"
 
 #include "base/compiler_specific.h"
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "net/base/address_list.h"
@@ skipping 51 matching lines @@
   DCHECK(!user_callback_);
   DCHECK(callback);
   DCHECK(response);
 
   if (net_log_.IsLoggingAllEvents()) {
     net_log_.AddEvent(
         NetLog::TYPE_HTTP_TRANSACTION_SEND_REQUEST_HEADERS,
         make_scoped_refptr(new NetLogHttpRequestParameter(
             request_line, headers)));
   }
+  VLOG(20) << __FUNCTION__ << "()"
+           << " request_line = \"" << request_line << "\""
+           << " headers = \"" << headers.ToString() << "\"";

[Randy Smith (Not in Mondays), 2011/05/03 21:30:41]

I'd be inclined to separate out pure logging changes if they're the only changes
in a file, and I think the only changes in this file are for logging.

[ahendrickson, 2011/05/04 15:08:25]

I find myself putting these things in every time I want to debug something in
the downloads!  It's much easier than searching in the about:net-internals for
the matching section (and fewer steps to get the info).

There are only 2 logging statements, one for the request and one for the
response.

   response_ = response;
 
   // Put the peer's IP address and port into the response.
   AddressList address;
   int result = connection_->socket()->GetPeerAddress(&address);
   if (result != OK)
     return result;
   response_->socket_address = HostPortPair::FromAddrInfo(address.head());
 
   std::string request = request_line + headers.ToString();
@@ skipping 467 matching lines @@
     read_buf_unused_offset_ = 0;
   } else {
     io_state_ = STATE_BODY_PENDING;
     user_read_buf_ = NULL;
     user_read_buf_len_ = 0;
   }
 
   return result;
 }
 
+static std::string GetResponseHeaderLines(const HttpResponseHeaders& headers) {
+  std::string raw_headers = headers.raw_headers();
+  const char* null_separated_headers = raw_headers.c_str();
+  const char* header_line = null_separated_headers;
+  std::string cr_separated_headers;
+  while (header_line[0] != 0) {
+    cr_separated_headers += header_line;
+    cr_separated_headers += "\n";
+    header_line += strlen(header_line) + 1;
+  }
+  return cr_separated_headers;
+}
+
 int HttpStreamParser::ParseResponseHeaders() {
   int end_offset = -1;
 
   // Look for the start of the status line, if it hasn't been found yet.
   if (response_header_start_offset_ < 0) {
     response_header_start_offset_ = HttpUtil::LocateStartOfStatusLine(
         read_buf_->StartOfBuffer() + read_buf_unused_offset_,
         read_buf_->offset() - read_buf_unused_offset_);
   }
 
@@ skipping 43 matching lines @@
     std::string content_length_value2;
     while (headers->EnumerateHeader(
         &it, content_length_header, &content_length_value2)) {
       if (content_length_value != content_length_value2)
         return ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_LENGTH;
     }
   }
 
   response_->headers = headers;
   response_->vary_data.Init(*request_, *response_->headers);
+  VLOG(20) << __FUNCTION__ << "()"
+           << " content_length = \""
+           << response_->headers->GetContentLength() << "\n\""
+           << " headers = \"" << GetResponseHeaderLines(*response_->headers)
+           << "\"";
   return OK;
 }
 
 void HttpStreamParser::CalculateResponseBodySize() {
   // Figure how to determine EOF:
 
   // For certain responses, we know the content length is always 0. From
   // RFC 2616 Section 4.3 Message Body:
   //
   // For response messages, whether or not a message-body is included with
@@ skipping 79 matching lines @@
 void HttpStreamParser::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   if (request_->url.SchemeIs("https") && connection_->socket()) {
     SSLClientSocket* ssl_socket =
         static_cast<SSLClientSocket*>(connection_->socket());
     ssl_socket->GetSSLCertRequestInfo(cert_request_info);
   }
 }
 
 }  // namespace net