Treat ERR_CONNECTION_CLOSED as end-of-data marker for downloads.

chrome/browser/safe_browsing/safe_browsing_database.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/safe_browsing_database.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/file_util.h"
@@ skipping 431 matching lines @@
   return FilePath(db_filename.value() + kBloomFilterFile);
 }
 
 // static
 FilePath SafeBrowsingDatabase::CsdWhitelistDBFilename(
     const FilePath& db_filename) {
   return FilePath(db_filename.value() + kCsdWhitelistDBFile);
 }
 
 SafeBrowsingStore* SafeBrowsingDatabaseNew::GetStore(const int list_id) {
-  DVLOG(3) << "Get store for list: " << list_id;

[Randy Smith (Not in Mondays), 2011/05/03 21:30:41]

I doubt this is part of your CL, so you probably don't want to change this file?

[Scott Hess - ex-Googler, 2011/05/03 21:50:29]

If this is the log line you refer to in the CC to me, then LGTM to remove.

BTW, I'd generally un-support adding new log lines unless you're convinced that
they would be totally useful for cases where you can't just re-compile Chromium.
 They may-or-may-not be cheap in execution time, but often enough the log line
which was obvious at point of insertion isn't obvious six months later when
someone is debugging things, so it's just a bunch of extra noise to read through
in the code.

[ahendrickson, 2011/05/04 15:08:25]

Since all our debugging happens at VLOG(20), this outputs a massive amount of
logging (making it look like Chrome is hung) when I try to debug.

I'd be happy to leave it in at VLOG(30) or something like that, if people think
it's necessary.

Oh, and list_id is always 1.

   if (list_id == safe_browsing_util::PHISH ||
       list_id == safe_browsing_util::MALWARE) {
     return browse_store_.get();
   } else if (list_id == safe_browsing_util::BINURL ||
              list_id == safe_browsing_util::BINHASH) {
     return download_store_.get();
   } else if (list_id == safe_browsing_util::CSDWHITELIST) {
     return csd_whitelist_store_.get();
   }
   return NULL;
@@ skipping 845 matching lines @@
   if (std::binary_search(new_csd_whitelist.begin(), new_csd_whitelist.end(),
                          kill_switch)) {
     // The kill switch is whitelisted hence we whitelist all URLs.
     CsdWhitelistAllUrls();
   } else {
     base::AutoLock locked(lookup_lock_);
     csd_whitelist_all_urls_ = false;
     csd_whitelist_.swap(new_csd_whitelist);
   }
 }