Issue 6881049: Depot Tools has been updated to revision EVERYTHING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6881049: Depot Tools has been updated to revision EVERYTHING (Closed)

Created:
9 years, 8 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Mohamed Mansour

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Only show "Depot Tools has been updated" messages when the tools are actually updated; show the real last-change revision and not the current HEAD revision. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82124

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	update_depot_tools	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/6881049/diff/1/update_depot_tools File update_depot_tools (right): http://codereview.chromium.org/6881049/diff/1/update_depot_tools#newcode47 update_depot_tools:47: svn info "$base_dir" | \ Can you add LANGUAGE=en ...

9 years, 8 months ago (2011-04-19 17:49:25 UTC) #2

Mark Mentovai

OK, I did LANG, LC_ALL, LC_CTYPE, and LC_MESSAGES, which should cover all of the bases.

9 years, 8 months ago (2011-04-19 17:56:02 UTC) #3

M-A Ruel

lgtm, thanks! http://codereview.chromium.org/6881049/diff/2002/update_depot_tools File update_depot_tools (right): http://codereview.chromium.org/6881049/diff/2002/update_depot_tools#newcode47 update_depot_tools:47: LC_ALL=C LC_CTYPE=C LC_MESSAGES=C LANG=C svn info "$base_dir" ...

9 years, 8 months ago (2011-04-19 17:57:35 UTC) #4

OK, LANGUAGE, then.

Expand Messages | Collapse Messages