Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 6881044: Change the Hydrogen representation of uses. (Closed)

Created:
9 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider, danno
CC:
v8-dev
Visibility:
Public.

Description

Change the Hydrogen representation of uses. Rather than representing a use as a pointer to an HValue and then searching for the specific (ambiguous) operand, we now represent a use as a pair of an HValue and the input operand index. Additionally, use a linked list instead of a growable array list since we never use random access. This allows us to remove a bunch of similarly named and subtly different functions from the HValue API. The cost in extra zone allocation per use is partially offset by reusing use list nodes when replacing a use of one value with another. R=danno@chromium.org,fschneider@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7674

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -293 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M src/hydrogen.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 15 chunks +81 lines, -160 lines 0 comments Download
M src/hydrogen-instructions.h View 12 chunks +77 lines, -18 lines 1 comment Download
M src/hydrogen-instructions.cc View 6 chunks +84 lines, -75 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +11 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-04-19 13:04:01 UTC) #1
danno
LGTM. I like it, it really cleans up the change insertion code. http://codereview.chromium.org/6881044/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h ...
9 years, 8 months ago (2011-04-20 04:25:12 UTC) #2
fschneider
9 years, 8 months ago (2011-04-20 10:36:52 UTC) #3
LGTM as well.

Powered by Google App Engine
This is Rietveld 408576698