Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/browser/sync/notifier/p2p_notifier.cc

Issue 6881042: [Sync] Fix race condition in P2PNotifier with sending notifications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | jingle/jingle.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/notifier/p2p_notifier.cc
diff --git a/chrome/browser/sync/notifier/p2p_notifier.cc b/chrome/browser/sync/notifier/p2p_notifier.cc
index 25c3182680746800519e0b7f9e7e3d6ae9540e02..46d9a9e95056b17096932020ec7b761e87322eb8 100644
--- a/chrome/browser/sync/notifier/p2p_notifier.cc
+++ b/chrome/browser/sync/notifier/p2p_notifier.cc
@@ -94,12 +94,7 @@ void P2PNotifier::SendNotification() {
notifier::Notification notification;
notification.channel = kSyncNotificationChannel;
notification.data = kSyncNotificationData;
- bool success = talk_mediator_->SendNotification(notification);
- if (success) {
- VLOG(1) << "Sent XMPP notification";
- } else {
- VLOG(1) << "Could not send XMPP notification";
- }
+ talk_mediator_->SendNotification(notification);
}
void P2PNotifier::OnNotificationStateChange(bool notifications_enabled) {
@@ -115,7 +110,7 @@ void P2PNotifier::OnIncomingNotification(
CheckOrSetValidThread();
VLOG(1) << "Sync received P2P notification.";
if (notification.channel != kSyncNotificationChannel) {
- LOG(WARNING) << "Notification fron unexpected source: "
+ LOG(WARNING) << "Notification from unexpected source: "
<< notification.channel;
}
MaybeEmitNotification();
« no previous file with comments | « no previous file | jingle/jingle.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698