Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 6881031: FileManager: Add thumbnail view. (Closed)

Created:
9 years, 8 months ago by rginda
Modified:
9 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

FileManager: Add thumbnail view. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82050

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -94 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +43 lines, -8 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 24 chunks +199 lines, -84 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 2 chunks +11 lines, -1 line 1 comment Download
M chrome/browser/resources/shared/js/cr/ui/list.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/shared_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zel
http://codereview.chromium.org/6881031/diff/1/chrome/browser/resources/file_manager/main.html File chrome/browser/resources/file_manager/main.html (right): http://codereview.chromium.org/6881031/diff/1/chrome/browser/resources/file_manager/main.html#newcode82 chrome/browser/resources/file_manager/main.html:82: onclick='fileManager.setListType(FileManager.ListType.DETAIL)' can you wire this callbacks as event listeners ...
9 years, 8 months ago (2011-04-19 01:21:09 UTC) #1
zel
9 years, 8 months ago (2011-04-19 01:21:28 UTC) #2
LGTM for everything else

Powered by Google App Engine
This is Rietveld 408576698