Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 6881029: update_kernel: be smarter (Closed)

Created:
9 years, 8 months ago by Olof Johansson
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

update_kernel: be smarter Auto-detect use of verity, and if verity is not used, copy over modules and firmware. Also, while I was at it, I added a --noreboot argument. And also copy over vmlinux.uimg on ARM if on non-verity. Change-Id: Ida9d3fbf4f342db65ebd0002a8b1a528440ea7fe BUG=chromium-os:13321 TEST=Build kernel, try updating on x86 and ARM, both with and without verity Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8488f5a

Patch Set 1 #

Patch Set 2 : oops, fix check for verity #

Patch Set 3 : echo -> info #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M update_kernel.sh View 1 2 5 chunks +36 lines, -20 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Olof Johansson
9 years, 8 months ago (2011-04-19 03:44:32 UTC) #1
Mandeep Singh Baines
http://codereview.chromium.org/6881029/diff/4001/update_kernel.sh File update_kernel.sh (right): http://codereview.chromium.org/6881029/diff/4001/update_kernel.sh#newcode39 update_kernel.sh:39: DEFINE_boolean reboot $FLAGS_TRUE "Reboot system after update" Why would ...
9 years, 8 months ago (2011-04-20 22:54:36 UTC) #2
Olof Johansson
http://codereview.chromium.org/6881029/diff/4001/update_kernel.sh File update_kernel.sh (right): http://codereview.chromium.org/6881029/diff/4001/update_kernel.sh#newcode39 update_kernel.sh:39: DEFINE_boolean reboot $FLAGS_TRUE "Reboot system after update" On 2011/04/20 ...
9 years, 8 months ago (2011-04-20 23:03:09 UTC) #3
Mandeep Singh Baines
9 years, 8 months ago (2011-04-20 23:08:46 UTC) #4
LGTM

olofj@chromium.org (olofj@chromium.org) wrote:
> 
> http://codereview.chromium.org/6881029/diff/4001/update_kernel.sh
> File update_kernel.sh (right):
> 
> http://codereview.chromium.org/6881029/diff/4001/update_kernel.sh#newcode39
> update_kernel.sh:39: DEFINE_boolean reboot $FLAGS_TRUE "Reboot system
> after update"
> On 2011/04/20 22:54:36, Mandeep Singh Baines wrote:
> >Why would you not want to reboot?
> 
> Mostly useful when testing the script, but seemed useful to add as an
> option instead of patching the script every time. I can take it out if
> you prefer.
> 

I guess leave it in until the script is stable. Just nice to keep options
to a minimum.

> http://codereview.chromium.org/6881029/

Powered by Google App Engine
This is Rietveld 408576698