Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 6881019: Fix SAFT to work on all x86 platforms using crossystem. (Closed)

Created:
9 years, 8 months ago by vb
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fix SAFT to work on all x86 platforms using crossystem. This is the second and final CL restoring SAFT functionality on X86 platforms. The first one was http://codereview.chromium.org/6849042/ This change - builds up the VECTOR_MAP to cover all legacy boot vector values - adds the provision to modify the map at run time on Mario (because Mario firmware always reports the recovery switch state as 'ON' if booted in recovery mode) - adds test cases to verify this map adjustment on Mario and to verify proper reporting of failed shel commands Change-Id: I9982f53ba8a5cc286eb8767686e714e22140f892 BUG=chrome-os-partner:2617 TEST=manual - run SAFT on Mario, Alex and ZGB, follow the directions (unplug and plug back in the USB flash stick a required). - Observe SAFT complete successfully (the /tmp/saft.log file contains 'We are done!' as the last line. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1bf1d8a

Patch Set 1 : Make SAFT work again. #

Total comments: 2

Patch Set 2 : Fix another Mario recovery reason shortcoming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -95 lines) Patch
M chromeos_interface.py View 1 3 chunks +122 lines, -70 lines 0 comments Download
M saft_utility.py View 8 chunks +17 lines, -16 lines 0 comments Download
M test_chromeos_interface.py View 3 chunks +47 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vb
9 years, 8 months ago (2011-04-19 15:29:46 UTC) #1
Randall Spangler
LGTM http://codereview.chromium.org/6881019/diff/4002/chromeos_interface.py File chromeos_interface.py (right): http://codereview.chromium.org/6881019/diff/4002/chromeos_interface.py#newcode162 chromeos_interface.py:162: partially built list, which is an indication of ...
9 years, 8 months ago (2011-04-19 19:40:32 UTC) #2
vb
I had to make yet another adjustment for Mario case (see the diffs). tested again, ...
9 years, 8 months ago (2011-04-19 21:15:22 UTC) #3
Randall Spangler
9 years, 8 months ago (2011-04-19 22:40:21 UTC) #4
LGTM again

Powered by Google App Engine
This is Rietveld 408576698