Issue 6881018: Switch back to using urlmon (from using Chrome's network stack) to upload metrics. This basicall...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6881018: Switch back to using urlmon (from using Chrome's network stack) to upload metrics. This basicall... (Closed)

Created:
9 years, 8 months ago by grt (UTC plus 2)

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Switch back to using urlmon (from using Chrome's network stack) to upload metrics so as to shrink npchrome_frame.dll. This basically reverts r58538. BUG=77445 TEST=uploading metrics should still work, although this is expected to reopen issue 54419. R=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82339

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -257 lines)			Patch
	M	chrome_frame/metrics_service.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome_frame/metrics_service.cc	View		4 chunks	+121 lines, -254 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Try job failure for 6881018-1 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=23316

9 years, 8 months ago (2011-04-20 15:50:42 UTC) #5

commit-bot: I haz the power

9 years, 8 months ago (2011-04-20 17:41:04 UTC) #6

Try job failure for 6881018-1 on mac:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

Expand Messages | Collapse Messages