Issue 6880303: Change about:flags page to now allow anyone but the owner modify it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6880303: Change about:flags page to now allow anyone but the owner modify it. (Closed)

Created:
9 years, 8 months ago by rkc

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews), zel

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Change about:flags page to not allow anyone but the owner modify it. Experiment flags are saved to local state, which makes then systemwide on Chrome OS; only the owner should be allowed to make system-wide changes, hence allow only the user to change the flags. BUG=chromium-os:13383 TEST=Tested with the owner accessing about:flags versus a non-owner. Non-owner is shown the warning, the owner is shown the regular page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83556

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -2 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/resources/flags_warning.html	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/flags_ui.cc	View	2 chunks	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages