fix mode=autoupdate on CR48

fix  mode=autoupdate on CR48

Change-Id: I7a260a1c3e6f0f4e673365cf8b65d9e869aabfa6

BUG=chromium-os:14654
TEST=chromeos-firmwareupdate --mode=autoupdate on Cr-48

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=63d99a5

[adlr, 2011-04-29 21:15:52]

Can you do a test from a month+ old R11 mario version to this?

If that works, LGTM

[jrbarnette, 2011-04-29 22:23:36]

http://codereview.chromium.org/6880299/diff/1/pack_stub
File pack_stub (right):

http://codereview.chromium.org/6880299/diff/1/pack_stub#newcode154
pack_stub:154: if  [ "${PLATFORM}" != "Mario" ]; then
Further down in this script (lines 232-234), there's similar code
to handle "legacy" firmware updaters.  That test checks for both
"Mario" and "ZGA".  Is this test here really supposed to be different?

If the tests should be the same, it's probably time to have a shell
function for determining "legacy".  O/W, the difference probably
needs to be explained in a comment.

[Stefan Reinauer, 2011-04-29 22:43:53]

http://codereview.chromium.org/6880299/diff/1/pack_stub
File pack_stub (right):

http://codereview.chromium.org/6880299/diff/1/pack_stub#newcode154
pack_stub:154: if  [ "${PLATFORM}" != "Mario" ]; then
On 2011/04/29 22:23:36, jrbarnette wrote:
> Further down in this script (lines 232-234), there's similar code
> to handle "legacy" firmware updaters.  That test checks for both
> "Mario" and "ZGA".  Is this test here really supposed to be different?
> 
> If the tests should be the same, it's probably time to have a shell
> function for determining "legacy".  O/W, the difference probably
> needs to be explained in a comment.

You are right, I will fix it to include ZGA too. Not sure if we really want to
care though, ZGA is pretty much dead and ZGB uses the new scheme

[jrbarnette, 2011-04-29 22:55:29]

On 2011/04/29 22:43:53, Stefan Reinauer wrote:
[ ... ]
> On 2011/04/29 22:23:36, jrbarnette wrote:
> > Further down in this script (lines 232-234), there's similar code
> > to handle "legacy" firmware updaters.  That test checks for both
> > "Mario" and "ZGA".  Is this test here really supposed to be different?
> > 
> > If the tests should be the same, it's probably time to have a shell
> > function for determining "legacy".  O/W, the difference probably
> > needs to be explained in a comment.
> 
> You are right, I will fix it to include ZGA too. Not sure if we really want to
> care though, ZGA is pretty much dead and ZGB uses the new scheme

If we think that we don't support ZGA anymore, now's a good time to
make that case and delete the code.  However, my guess is that we're
better off not dropping support for ZGA (yet).