SafeBrowsing Opt-in Malware Reports: Collect remote ip:port pairs for requests that were not fetc...

SafeBrowsing Opt-in Malware Reports: Collect remote ip:port pairs for requests that were not fetched via a proxy.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85022

[mattm, 2011-05-10 21:26:30]

http://codereview.chromium.org/6880285/diff/5001/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/malware_details_cache.cc (right):

http://codereview.chromium.org/6880285/diff/5001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/malware_details_cache.cc:170: net::HostPortPair
socket_address = source->socket_address();
Could go in the if block, or just do it inline in the function call?

http://codereview.chromium.org/6880285/diff/5001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/malware_details_cache.cc:172:
pb_response->set_remote_ip(socket_address.ToString());
Can the test be updated to check this?

[panayiotis, 2011-05-10 21:47:36]

http://codereview.chromium.org/6880285/diff/5001/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/malware_details_cache.cc (right):

http://codereview.chromium.org/6880285/diff/5001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/malware_details_cache.cc:170: net::HostPortPair
socket_address = source->socket_address();
On 2011/05/10 21:26:30, mattm wrote:
> Could go in the if block, or just do it inline in the function call?

Done.

http://codereview.chromium.org/6880285/diff/5001/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/malware_details_cache.cc:172:
pb_response->set_remote_ip(socket_address.ToString());
On 2011/05/10 21:26:30, mattm wrote:
> Can the test be updated to check this?

Done.

[mattm, 2011-05-10 22:12:06]

LGTM

[Brian Ryner, 2011-05-11 17:35:36]

LGTM

[commit-bot: I haz the power, 2011-05-11 19:50:37]

Change committed as 85022