Sometimes avoid checking whether the receiver is an object in generated code.

Sometimes avoid checking whether the receiver is an object in generated code.

In unoptimized code, use the version of the CallFunctionStub that does not
check whether its receiver is an object in all the cases where we statically
know that it is an object.

R=ager@chromium.org,sgjesse@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=7698

[Kevin Millikin (Chromium), 2011-04-28 08:54:35]

This was a simple optimization that we had in the classic backend and never
implemented in the baseline compiler.

http://codereview.chromium.org/6880268/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6880268/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:2163: void FullCodeGenerator::EmitCallWithStub(Call*
expr, CallFunctionFlags flags) {
The flags value is NO_CALL_FUNCTION_FLAGS at all call sites of EmitCallWithStub,
so I could have just flipped the constant value in this function.

I made it an argument to try to force new call sites to be specific because
NO_CALL_FUNCTION_FLAGS is not a safe default.

[Mads Ager (chromium), 2011-04-28 08:59:01]

LGTM!

http://codereview.chromium.org/6880268/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

http://codereview.chromium.org/6880268/diff/1/src/ia32/full-codegen-ia32.cc#n...
src/ia32/full-codegen-ia32.cc:2194: __ int3();
Whoops. :-)

[Kevin Millikin (Chromium), 2011-04-28 09:00:03]

http://codereview.chromium.org/6880268/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

http://codereview.chromium.org/6880268/diff/1/src/ia32/full-codegen-ia32.cc#n...
src/ia32/full-codegen-ia32.cc:2194: __ int3();
On 2011/04/28 08:59:01, Mads Ager wrote:
> Whoops. :-)

Yeah, that's not the intended behavior.