Issue 6880241: Disable warnings in VS since they won't be fixed anytime soon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6880241: Disable warnings in VS since they won't be fixed anytime soon. (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/libjpeg_turbo/

Visibility:
Public.

Description

Disable warnings in VS since they won't be fixed anytime soon. This is to enable warnings as error. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83675

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	libjpeg.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Now, only need to disable the yasm warnings. http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/224/steps/compile/logs/stdio

9 years, 8 months ago (2011-04-27 17:33:11 UTC) #1

Hironori Bono

9 years, 8 months ago (2011-04-28 10:44:10 UTC) #2

LGTM.
Thank you for disabling these warnings. I have merged libjpeg-turbo that fixed
all yasm warnings to Chromium. (This change is r83322 <http://crrev.com/83322>.)

Regards,

Hironori Bono

Expand Messages | Collapse Messages